Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet speed is for client not server #26

Closed
tlunter opened this issue Jan 27, 2014 · 8 comments
Closed

Internet speed is for client not server #26

tlunter opened this issue Jan 27, 2014 · 8 comments

Comments

@tlunter
Copy link

tlunter commented Jan 27, 2014

Seeing as how the Internet Speed is just a JS function that downloads an image from google, the metric is for the client not the server.

This is pretty irrelevant on a server status page I would think.

Should be another PHP script that does something similar.

@andreyvital
Copy link
Contributor

Hey,
Why i should go to my _server dashboard_ to see my internet connection speed ?

The dashboard is for server metrics, not yours.
Hugs.

@tlunter
Copy link
Author

tlunter commented Jan 28, 2014

Just checking here, @andreyknupp, but you're agreeing?

@andreyvital
Copy link
Contributor

Nope, i'm not agreeing with your issue.

@tlunter
Copy link
Author

tlunter commented Jan 28, 2014

https://github.com/afaqurk/linux-dash/blob/master/js/magic_happens_here.js#L241

This is how the server dashboard currently gets internet connection speed. It downloads an image from google via your browser and never interacts with the server. The internet connection has absolutely nothing to do with the server at this point in time. Is that not what you're saying when you want server metrics and not yours?

@andreyvital
Copy link
Contributor

Okay
Now i understand, that's because i don't have seen full project.

When i've read your issue, i say: "hey, what's going ? this guy is talking about show his connection speed at server dashboard", but not.

And now, re-reading the issue, you're absolutely correct.
Doesn't make any sense of downloading an image at client side and guessing it's server connection speed, whopz.

Thanks, @tlunter.
[]'s

@ghost
Copy link

ghost commented Jan 28, 2014

This really needs a revision. Might do this one and pull request.

@andreyvital
Copy link
Contributor

At pull #39 guys.

speed.php -> a859971

tariqbuilds added a commit that referenced this issue Jan 29, 2014
correctly testing internet speed (#26)
@tariqbuilds
Copy link
Owner

Thanks for the very useful issue and fix, guys. Appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants