-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internet speed is for client not server #26
Comments
Hey, The dashboard is for server metrics, not yours. |
Just checking here, @andreyknupp, but you're agreeing? |
Nope, i'm not agreeing with your issue. |
https://github.com/afaqurk/linux-dash/blob/master/js/magic_happens_here.js#L241 This is how the server dashboard currently gets internet connection speed. It downloads an image from google via your browser and never interacts with the server. The internet connection has absolutely nothing to do with the server at this point in time. Is that not what you're saying when you want server metrics and not yours? |
Okay When i've read your issue, i say: "hey, what's going ? this guy is talking about show his connection speed at server dashboard", but not. And now, re-reading the issue, you're absolutely correct. Thanks, @tlunter. |
This really needs a revision. Might do this one and pull request. |
correctly testing internet speed (#26)
Thanks for the very useful issue and fix, guys. Appreciate it! |
Seeing as how the Internet Speed is just a JS function that downloads an image from google, the metric is for the client not the server.
This is pretty irrelevant on a server status page I would think.
Should be another PHP script that does something similar.
The text was updated successfully, but these errors were encountered: