Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event: fix backtab behaviour on config pane #110

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

miraclx
Copy link
Contributor

@miraclx miraclx commented Feb 26, 2021

My bad on #104, #70 takes a while to get used to.

@tarkah
Copy link
Owner

tarkah commented Feb 26, 2021

Good thing this isn't really too critical :P

@tarkah tarkah merged commit a80089d into tarkah:master Feb 26, 2021
@tarkah
Copy link
Owner

tarkah commented Feb 26, 2021

@miraclx Can you make sure to update the CHANGELOG on future changes, especially like this where it fixes a bug that someone might encounter. I've gone ahead and updated it on master.

@miraclx
Copy link
Contributor Author

miraclx commented Feb 27, 2021

Got it, will do!

@miraclx miraclx deleted the config-pane-fix-backtab branch February 27, 2021 00:19
@tarkah
Copy link
Owner

tarkah commented Feb 27, 2021

@miraclx I saw you just found / starred Ajour! We could use some contributions from you there as well :)

@miraclx
Copy link
Contributor Author

miraclx commented Feb 27, 2021

Oh...

Yeah, I was really stunned by how beautiful it is. I sure stand corrected on the state of pure-rust GUI libraries. I was going to use Qt bindings for my next GUI projects (freyr-gui for instance) but now, I'm inspired to actually use iced or something similar.

And yeah, I'd love to contribute but unfortunately I don't play WoW, I never get past the Welcome to Ajour (Select Directory) screen.

But great work, it looks stunning from the screenshots!

@tarkah
Copy link
Owner

tarkah commented Feb 27, 2021

Yeah, Casper, the creator, has a really good eye and has made it look really nice. There's definitely still a lot of shortcomings with iced, but it's worked out since we set out to keep Ajour minimalistic from the get go.

Once there's more mature support for overlay widgets, iced will be more enjoyable to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants