Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #68

Merged
merged 3 commits into from
Feb 16, 2021
Merged

update dependencies #68

merged 3 commits into from
Feb 16, 2021

Conversation

tarkah
Copy link
Owner

@tarkah tarkah commented Feb 16, 2021

Breaking changes to tui-rs library for this big dependency update

@tarkah
Copy link
Owner Author

tarkah commented Feb 16, 2021

@miraclx would you be able to help test this branch and confirm there are no visual differences between it and 0.11.0?

I'm many versions behind on the tui library I'm using, and updating to the latest version had some pretty big API breakages that caused me to have to change how certain things are rendered. Everything looks good on my end, but I'd appreciate another set of eyes / different terminals to really confirm.

@miraclx
Copy link
Contributor

miraclx commented Feb 16, 2021

Hm, assuming we even use different terminals or have different perspectives on how things should look 😅 (hint: I doubt it)

I'm testing it anyways

@tarkah
Copy link
Owner Author

tarkah commented Feb 16, 2021

I'm just wanting to make sure things look near identical with the changes made. I've tested with Dark and Light themes using windows terminal and alacritty on linux.

It appears I'm now setting the text to "White" instead of the default foreground color of the users terminal. I need to switch this back. Otherwise things look good.

@miraclx
Copy link
Contributor

miraclx commented Feb 16, 2021

LGTM;

I did notice the whites (color) in group (or block?) headers were in a sense, "brighter" in this version, I haven't peered through the code yet but this is very trivial, so in a sense, it's pretty good.

EDIT: I wrote this before your last comment came in, apparently it didn't send

@miraclx
Copy link
Contributor

miraclx commented Feb 16, 2021

In ref to ~1

Screenshot_20210216_214034 Screenshot_20210216_214044
v0.11.0 #68

EDIT: I actually like these new whites, they look more vibrant
EDIT: just did a pull, the recent changes reversed that, it's back to the former now

@tarkah
Copy link
Owner Author

tarkah commented Feb 16, 2021

Yeah, I'm torn on if I should keep it white or foreground color. I think I'll keep it as foreground, but when I eventually add theming, I'll have a distinct color for text?

@miraclx
Copy link
Contributor

miraclx commented Feb 16, 2021

I agree with that, and having those theming options is the literal best.
+1 from me on this PR

@tarkah
Copy link
Owner Author

tarkah commented Feb 16, 2021

Awesome! Now that this is done, I'll be working on theme support next

@tarkah tarkah merged commit 4ba57c0 into master Feb 16, 2021
@tarkah tarkah deleted the chore/update-deps branch February 16, 2021 21:58
@miraclx miraclx mentioned this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants