-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing to standard output #74
Comments
This was fixed for a line in components/common_modules/tree.py (which contained the print statement that first alerted us to this problem). |
Removed writing error report to stdout in commit 7cc7060. |
Open
marcverhagen
added a commit
that referenced
this issue
Sep 7, 2018
Checked all print statements in the code and removed the dangerous ones or replaced them with calls to the logger. Print statements were allowed on some spots:
|
Fixed in a9662a1. |
marcverhagen
added a commit
that referenced
this issue
Oct 17, 2018
Removed potentially dangerous uses of print statement (issue #74).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are many occasions where TTK writes to standard output. This is not a good idea when you use the --pipe option. Printing to stdout is okay when processing a directory, but printing to stdout in standard file or pipe processing should be eliminated.
Find all those occasions and replace them with calls to the logger or write to stderr.
The text was updated successfully, but these errors were encountered: