Fix GraphiQL subscriptions endpoint when using ASGI sub-mounting #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thanks @v-do! Is there any chance we can add a test for this? Eg setup subscriptions on an app mounted at /some/path and verify that the full path (not just eg /subscriptions) is present in the rendered template. (Not sure if there’s such a test for the API endpoint already.) |
|
Hi @florimondmanca yep sure let me try adding a test for it |
v-do
force-pushed
the
mount-graphiql-subscriptions
branch
from
dc70f20
to
e2a1c26
Compare
florimondmanca
approved these changes
Nov 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
TartifletteAppinstance is mounted as a sub-route of another ASGI application, the GraphiQL subscriptions endpoint does not add the mount path and so subscriptions do not work from GraphiQL.