Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11 #363

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Add support for Python 3.11 #363

merged 1 commit into from
Nov 4, 2022

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 29, 2022

Fixes #360.

Python 3.11 was released on 2022-10-24.

image

@hugovk hugovk mentioned this pull request Oct 29, 2022
Copy link
Owner

@tartley tartley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, thank you! Can you answer my minor question? But I'll merge it as-is to maintain momentum. Thank you!

@@ -22,12 +22,13 @@ jobs:
- {python-version: "3.8", toxenv: "py38"}
- {python-version: "3.9", toxenv: "py39"}
- {python-version: "3.10", toxenv: "py310"}
- {python-version: "3.11", toxenv: "py311"}

steps:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand these v2 -> v3 changes? I'm not as familiar as I should be with githhub actions. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, GitHub Actions are usually pinned to a major version. (Some projects pin to minor, patch or even Git SHAs, but major is most common.)

New major versions indicate breaking changes, but with GitHub Actions, it's often nothing to worry about, and can be something like they're using a newer Node version internally.

So it's a good idea to update them once in a while, there can be new features, like actions/setup-python added builtin caching at some point. And the older versions will stop working at some point, for example they may use APIs that are deprecated/removed, or using an unsupported version of Node.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps! Much appreciated.

@@ -1,6 +1,6 @@
[tox]
isolated_build = true
envlist = py27, py37, py38, py39, py310, pypy, pypy3
envlist = py{27, 37, 38, 39, 310, py, py3}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beaut

@tartley tartley merged commit 21c4b94 into tartley:master Nov 4, 2022
@hugovk hugovk deleted the add-3.11 branch November 4, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python3.11
2 participants