Fixed NFR03 #10
Merged
Fixed NFR03 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CHECK BELOW FOR RELEVANT LINES OF CODE FOR REVIEW]
Bug: Unconfirmed status of track supervisor was applied whenever the save button was pressed (with updates or not) in the Scheduling screen with the following statuses:
Range officer present
Range officer confirmed
Range officer on the way
Other statuses were unaffected.
Solution: There was a bit of code that set the track supervisor to unconfirmed in the previous cases, intended to "reset" the track supervisor whenever the track supervisor was changed in the Schedules screen. This was fixed by making the system remember the original track supervisor id and then comparing the one that is being saved to this value. If it differs, then the track supervisor is set to unconfirmed, otherwise the status remains as it was.
Relevant lines of code (in the modified file):
87
157
597