Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests and eslint #26

Merged
merged 26 commits into from
Nov 3, 2020
Merged

Tests and eslint #26

merged 26 commits into from
Nov 3, 2020

Conversation

TuoLuo994
Copy link
Contributor

No description provided.

@Liljenmaa
Copy link
Contributor

Looks like the superuser's schedule system will always post "track supervision TypeError: this.state.tracks[key] is undefined" after any edit. This isn't limited to uninitialized dates.

Shandorin
Shandorin approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@Shandorin Shandorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. there was one interesting error that resulted in crash once when changing languace in quick succession, but propably not related to this change. tried to replicate, but only got logged out after repeating.

@TuoLuo994 TuoLuo994 merged commit e63c3f7 into develop Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shandorin Shandorin Shandorin approved these changes

@lkyostila lkyostila lkyostila approved these changes

@DevOlli DevOlli Awaiting requested review from DevOlli

@EliasHP EliasHP Awaiting requested review from EliasHP

@Liljenmaa Liljenmaa Awaiting requested review from Liljenmaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TuoLuo994 @Liljenmaa @lkyostila @Shandorin @EliasHP