Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance messages for command #21

Merged
merged 4 commits into from
Mar 19, 2022
Merged

Conversation

task4233
Copy link
Owner

Overview

Current commands provided by dl are cheap. Thus, this PR enhances them for users.

@task4233 task4233 added the enhancement New feature or request label Mar 19, 2022
@task4233 task4233 self-assigned this Mar 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #21 (c8d9c3e) into main (b7d1fad) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   77.07%   76.92%   -0.15%     
==========================================
  Files           3        3              
  Lines         157      156       -1     
==========================================
- Hits          121      120       -1     
  Misses         20       20              
  Partials       16       16              
Impacted Files Coverage Δ
cli.go 77.21% <100.00%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7d1fad...c8d9c3e. Read the comment docs.

@task4233
Copy link
Owner Author

This decrease has no effect on current test cases. Thus, ignore it.

Copy link
Owner Author

@task4233 task4233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@task4233 task4233 merged commit eaad89a into main Mar 19, 2022
@task4233 task4233 deleted the feat/enhance-messages-for-command branch March 19, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants