This repository has been archived by the owner on Nov 12, 2019. It is now read-only.
compatibility with listClients API #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From reading the associated auth PR, it looks like during the transition to the new API, it will switch from returning the clients in an array to returning the array at the When the API switches to have a cc: @djmitche |
|
Yes, that's precisely the idea. It's a breaking change, and the point of this PR is to make tools work both with the old and new response bodies. |
eliperelman
approved these changes
Apr 9, 2018
djmitche
reviewed
Apr 9, 2018
| const clientResponse = await this.props.auth.listClients( | ||
| clientPrefix ? { prefix: clientPrefix } : null | ||
| ); | ||
| const clients = |
There was a problem hiding this comment.
It might be good to put a comment in here pointing to the bug.
There was a problem hiding this comment.
Added a relevant message to the listClients API call
eliperelman
approved these changes
Apr 10, 2018
|
Thanks for your work here @tuhina2020! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taskcluster/taskcluster-auth#148
https://bugzilla.mozilla.org/show_bug.cgi?id=1436212
Handled the refactoring of listClients API @djmitche