Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upstash): don't throw an error when detecting an upstash host #1756

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

chronark
Copy link
Contributor

Upstash is currently rolling out redis streams to all remaining regions and will be compatible with bullmq.
This draft is just a preparation for when the time comes.

Please let me know if you're happy with these changes.

Upstash is currently rolling out redis streams to all regions and will be compatible with bullmq.
@manast
Copy link
Contributor

manast commented Mar 29, 2023

LGTM. But I think we need to wait to merge until the support has reached all regions.
EDIT. Ok sorry now I re-read your comment and this was what you were suggesting 😂

@sayaad
Copy link

sayaad commented Apr 11, 2023

It seems like upstash fully supports streams now.
https://docs.upstash.com/redis/overall/rediscompatibility
I'm patiently waiting for this commit so I can switch redis hosts to upstash.

@roggervalf roggervalf marked this pull request as ready for review April 11, 2023 22:03
@manast manast merged commit 2e06bca into taskforcesh:master Apr 17, 2023
@chronark chronark deleted the remove-upstash-error branch April 18, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants