Adds 'images_urls' and 'has_video' attributes to tweets #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rezemika This looks like an useful addition, but don't you want to write the retrieved information to the output file? |
Now, a Tweet object contains: - an 'images_urls' attribute, which is a list containing the urls of the images of tweet; - a 'has_video' attribute, which a boolean, set to True if the tweet has a video, false either. It is currently not possible to get the video url, because it does not come with the tweet HTML (it seems to be added after loading with Javascript).
rezemika
force-pushed
the
tweet-images
branch
from
b2ff956
to
c0abaed
Compare
|
Oh, my bad, I forgot that. It should be fixed now. :) |
|
This PR should be closed because the similar changes were merged on #231. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I made small modifications to be able to download the images coming with a tweet. I thought it might be useful. :)
By the way, it's related to #200.
Now, a Tweet object contains:
It is currently not possible to get the video url, because it does not come with the tweet HTML (it seems to be added after loading with Javascript).
Edit: Videos are added by an obfuscated script, which uses an API requiring parameters which are very difficult to get (they're hidden in an unreadable bloat of JS). The URL of the API is something like
https://api.twitter.com/1.1/videos/tweet/config/XXX.json(with XXX = the ID of the tweet), it requires an authorization header and some cookies.