This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Add phone outline, re-shoot and process images #130
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #14.
Re-took screenshots of all implementations with Chrome on iPhone6-view and processed them all with
pngquant
.Creates an outline of a generic modern smartphone with 44lines of Scss.
Reduces network load on desktop (with images) from 7.2mb to 3.3mb. Which is still not really small. The height of the screenshots could be halved, but this would make them less nice on a hdpi display.
One issue with this PR might be that all current pull requests will have the 'wrong' image with a phone in it.
If you'd like I'll update the docs on how to take a screenshot
Example