Fix toggle-all input not being checked #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure it's not needed for the other selectors? |
Yes, this is my revised version. https://codesandbox.io/s/todomvc-changed-2lfs4?file=/index.html The change of z-index may cause some elements can't be selected. So I used this static page to test all the elements that can be clicked, and they can all be triggered normally. |
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #37 .
When the new-todo input is selected, its z-index is greater than toggle-all input, resulting in the toggle-all input can't be checked.
So I removed changing the z-Index property when an element is selected.