Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open link in a new tab? #48

Closed
Pegahkeshavarz opened this issue Aug 31, 2017 · 10 comments
Closed

open link in a new tab? #48

Pegahkeshavarz opened this issue Aug 31, 2017 · 10 comments

Comments

@Pegahkeshavarz
Copy link

Is there anyway to open the link in a new tab? right now it opens it in the same tab

@joojis
Copy link

joojis commented Sep 4, 2017

According to the demo(http://tasti.github.io/react-linkify/),

<Linkify properties={{target: '_blank'}> ... </Linkify>

And I think this is a frequent use case, but the current interface isn't intuitive enough. IMHO.
Is there any improvement idea on this? @tasti

@tasti
Copy link
Owner

tasti commented Sep 7, 2017

One possibility is instead of using properties, you can just place the props you want each of your links to have directly on Linkify. For example:

<Linkify target="_blank">...</Linkify>

My worry here is that there may be some overlap that isn't ideal, where there's a prop on Linkify that is also on a but with different values. I think there are little to none of these, and seems to be more intuitive.

@jb-reefer
Copy link

@tasti I'd be happy to implement the target idea and make a PR if you're interested

@tasti
Copy link
Owner

tasti commented Sep 15, 2017

Would love to include this, give it a shot :)

@dharness
Copy link

@jb-reefer presuming this didn't happen?

@jb-reefer
Copy link

jb-reefer commented Nov 14, 2017

@dharness never got a shot - I can work on it this weekend, but if you want to do it feel free!

@jb-reefer jb-reefer mentioned this issue Nov 22, 2017
@jb-reefer
Copy link

@dharness submitted a PR!

@dharness
Copy link

Hey didn't expect that! Much appreciated!

@tasti tasti mentioned this issue Jan 6, 2018
16 tasks
@tasti
Copy link
Owner

tasti commented Jan 7, 2018

See #51 (comment).

@tasti tasti closed this as completed Jan 7, 2018
@Jayanth998
Copy link

Add target: "_blank" property as part of options prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants