Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tasks and fix Draco 3 example #58

Merged
merged 33 commits into from
Jun 21, 2023
Merged

Conversation

stephane-caron
Copy link
Owner

  • Fix Draco 3 example
  • Cost vector is now defined for all tasks
  • Levenberg-Marquardt damping is now defined for all tasks, with a default to zero

This fixes numerical instability
This is because the frame task has separate setters for position and
orientation costs.
Convention for list naming
@stephane-caron
Copy link
Owner Author

@ymontmarin This PR is ready for review. 🕵️

Copy link
Collaborator

@ymontmarin ymontmarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just finished reading all the diff, looks fine to me, maybe in future PR we can have an automatic repr generation in task parent class instead of rewriting for every child, it will still output the sam repr string. I can do it if you think it is useful for readabillity of the code

@stephane-caron
Copy link
Owner Author

Thank you for checking 😃

I can do it if you think it is useful for readabillity of the code

Currently it's readable but a bit dumb 😅 It fits the fact that some child classes add their own attributes to the repr (e.g. frame task adding its target).

If auto repr generation is simple enough to maintain and reduces the amount of boilerplate code I'm all for it 👍

@stephane-caron stephane-caron merged commit 158588d into master Jun 21, 2023
@stephane-caron stephane-caron deleted the fix/draco3_example branch July 19, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants