Changes to CartCondition helper

[ryanmitchell]

Flame related changes: tastyigniter/TastyIgniter#481

[sampoyigi]

I'm guessing this is no longer needed, can you close this and related PRs

[ryanmitchell]

This relates to the coupon changes - it's still needed to allow the calculation of the discount based on what items are eligible (due to category or product restrictions)

[sampoyigi]

Ok, let me see if i can come up with a different approach, also have you transferred the extension over to TI? I want to start the review process on time

[ryanmitchell]

Havent transferred yet, was waiting for you to come back on the questions from the core models - I'll work on the events approach over the weekend or at the start of next week.

[ryanmitchell]

@sampoyigi what about this sort of approach? In summary:

add limitations array to CartCondition
which we then loop over in processValue() to recalculate total on the basis of
see here for the coupon side of it:

tastyigniter/ti-ext-coupons@e91cd6c

[sampoyigi]

Got a different approach in mind, I will get started on it and push once I have it pieced together.

[ryanmitchell]

👍

[sampoyigi]

See it here #19, some improvements can definitely be made.

[ryanmitchell]

Am I good to close this (nothing is depending on it?)

[sampoyigi]

Yup!