Change fire to dispatch as fire is deprecated #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampoyigi
reviewed
Nov 5, 2021
| @@ -44,7 +44,7 @@ public function registerCurrency() | |||
| { | |||
| $this->app->singleton('currency', function ($app) { | |||
|
|
|||
| $this->app['events']->fire('currency.beforeRegister', [$this]); | |||
| $this->app['events']->dispatch('currency.beforeRegister', [$this]); | |||
There was a problem hiding this comment.
The fire method was reinstated in Igniter\Flame\Events\Dispatcher for backward compatibility, so fire should still work here as long as the instance of the events within the container is the same one from the flame library.
There was a problem hiding this comment.
Yep, should have said this is coming from the composer package work. So app events wont be a flame app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.