Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cu tile names #303

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Cu tile names #303

merged 4 commits into from
Dec 2, 2023

Conversation

jzwar
Copy link
Collaborator

@jzwar jzwar commented Nov 14, 2023

Overview

Renaming and adaptation to style guide

Requires some of the open PRs to update their naming conventions.

Addressed issues

Effected PRs

Checklists

  • Documentations are up-to-date.
  • Added example(s)
  • Added test(s)

@jzwar jzwar requested a review from j042 November 14, 2023 11:12
@jzwar jzwar marked this pull request as ready for review November 14, 2023 11:12
j042
j042 requested changes Nov 15, 2023
View reviewed changes
splinepy/microstructure/tiles/ellipse_void.py Outdated Show resolved Hide resolved
splinepy/microstructure/tiles/snappy.py Outdated Show resolved Hide resolved
splinepy/microstructure/tiles/double_lattice.py Outdated Show resolved Hide resolved
@j042 j042 added enhancement New feature or request documentation Improvements or additions to documentation labels Nov 24, 2023
@jzwar jzwar requested a review from j042 November 30, 2023 23:16
j042
j042 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@j042 j042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! a look up chart, where we can get an overview of dimensions, could be nice(tiles.P2D2 ...). Maybe next PR?

jzwar and others added 4 commits December 1, 2023 16:07
@jzwar @j042
Delete unused file
15181e8
@jzwar @j042
Renamed all files according to style guide
b95aea4 
Renaming all tiles and adapted their file names to fit the style guide
@jzwar @j042
Last renaming and documentation +para_dim
b2292df
@jzwar @j042
Update splinepy/microstructure/tiles/tile_base.py
abe80c9 
Co-authored-by: Jaewook Lee <47114801+j042@users.noreply.github.com>
@j042 j042 merged commit 377fa19 into main Dec 2, 2023
21 checks passed
@j042 j042 deleted the cu-tile-names branch December 2, 2023 11:14
@j042 j042 mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j042 j042 j042 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzwar @j042