Feature: leading underscore to module imports #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeRealMF
force-pushed
the
ft-local-import
branch
from
93df471
to
6bc1963
Compare
SeRealMF
force-pushed
the
ft-local-import
branch
from
f076829
to
089a5c0
Compare
SeRealMF
changed the title
j042
reviewed
Nov 17, 2023
j042
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
I think we can leave function-local-import also this way for now. They are mainly for type checking and we can try to avoid in other PR. Thanks again!
This will cause some conflicts on other PRs (@jzwar, @FSchwar, @clemens-fricke), but other way around would cause bigger conflicts. So, I will merge this first
|
When will this be merged? Is anything missing still? |
right now |
mkofler96
pushed a commit
to mkofler96/splinepy
that referenced
this pull request
Dec 4, 2023
* added leading underscore * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added leading underscore * direct module import * fixed formatting * bug fixes * Apply suggestions from code review * update contributing --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jaewook Lee <47114801+j042@users.noreply.github.com> Co-authored-by: Jaewook Lee <jaewooklee042@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Leading underscores were added to the module imports to make them private. This means that they are not accessible from outside the module and can only be used within the module itself.
Addressed issues
#270
Showcase