Allow to override UserAgent#113
Merged
Merged
Conversation
Adding on command line the user agent add a duplicate header: ``` ./w3m -header "User-Agent: Mozilla" http://localhost:9999 GET / HTTP/1.0 User-Agent: w3m/0.5.3+git20190105 Accept: text/html, text/*;q=0.5, image/*, application/*, message/*, x-scheme-handler/*, audio/*, video/*, inode/* Accept-Encoding: gzip, compress, bzip, bzip2, deflate Accept-Language: en;q=1.0 Host: localhost:9999 Pragma: no-cache Cache-control: no-cache User-Agent: Mozilla ``` As a result most server will take the first given; the default w3m_version or the one defined on config `user_agent` With this patch we can now override `User-Agent` from command line
Owner
The config value can be set by |
Contributor
Author
Cool thanks for the info, but don't you find its a strange behavior ? I've checked with |
Owner
|
Anyway, preventing User-Agent twice is reasonable. Merged, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Adding on command line the user agent add a duplicate header:
As a result most server will take the first given; the default
w3m_version or the one defined on config
user_agentWith this patch we can now override
User-Agentfrom command lineCheers,
Laurent