Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support VRMSpringBone #8

Merged
merged 29 commits into from
Dec 29, 2019
Merged

Add support VRMSpringBone #8

merged 29 commits into from
Dec 29, 2019

Conversation

noppefoxwolf
Copy link
Contributor

@noppefoxwolf noppefoxwolf commented Dec 21, 2019 •
edited
Loading

TODO

  • macOS build
    • remove GLKit dependency
  • review algorithm

noppefoxwolf
noppefoxwolf commented Dec 21, 2019
View reviewed changes
VRMKit.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
VRMKit.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@noppefoxwolf noppefoxwolf changed the title Add support VRMSpringBone [WIP]Add support VRMSpringBone Dec 21, 2019
@noppefoxwolf noppefoxwolf changed the title [WIP]Add support VRMSpringBone Add support VRMSpringBone Dec 28, 2019
@noppefoxwolf
Copy link
Contributor Author

@tattn Hi, I'm sorry to keep you waiting for my work.
I completed that implement springbone for VRMKit.
Please review my PR :)

@tattn
Copy link
Owner

tattn commented Dec 28, 2019

Thanks for your amazing PR 👍:+1: 👍
This feature is what everyone wants ✨
I'll review it.

tattn
tattn reviewed Dec 28, 2019
View reviewed changes
Example/ViewController.swift Outdated Show resolved Hide resolved
tattn
tattn reviewed Dec 29, 2019
View reviewed changes
Example/ViewController.swift Outdated Show resolved Hide resolved
noppefoxwolf and others added 3 commits December 29, 2019 13:44
@tattn
Copy link
Owner

tattn commented Dec 29, 2019

@noppefoxwolf
Thank you for contributing and communication 😄
It's the awesome awesome awesome implementation 🎉 I have nothing else to review 🐱
Is it OK to merge? I'll publish it as the version 0.4.0. 🚀

@noppefoxwolf
Copy link
Contributor Author

@tattn
Of course! Please merge this PR.

But I forgot change platform on Package.swift.
#11
Please merge it before release.

@tattn
Copy link
Owner

tattn commented Dec 29, 2019

@noppefoxwolf
Thanks a million until the end! 🙌
I'll merge it :octocat:

@tattn tattn merged commit a9ce236 into tattn:master Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tattn tattn tattn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noppefoxwolf @tattn