Callback reply support #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A callback to the backend can have a reply handler on the frontend. This makes it more convenient to add things like indicators that are running while processing is taking place.
Check both components and callbacks to consider a context empty.
Send success if return value is a map containing :ripley/success and wrap that to backend callbacks. This prevents client from trying to exfiltrate data by saying it has a handler even when one wasn't intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support adding
on-successandon-failurecallbacks on the client side.If an on-success is provided, the return value is sent to the client and the callback invoked with it. The return value of the server callback function must be serializable to JSON.
If an on-failure is provided, any throwable thrown during server callback invocation is caught and send to the client as a JSON object with
messagekey containing the message and any context.Added Playwright tests for both.