Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows to 0.39.0 #544

Merged
merged 6 commits into from
Aug 31, 2022
Merged

Update windows to 0.39.0 #544

merged 6 commits into from
Aug 31, 2022

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Aug 31, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

The alloc feature has been removed, which means Win32 APIs no longer accept Rust String or &str parameters and implicitly convert them to PWSTR or PSTR.

For string literals, that feature was replaced with s!() and w!() macros which null terminate the string literal at compile time and convert to UTF-16 if necessary. The s!() macro is fine, however the w!() macro uses HSTRING types from WinRT for maximum compatibility with WinRT types. Since Tao only uses Win32 APIs (or dynamically loaded DLL entry-points), it still works on Win7, but I'm worried about taking any dependencies on HSTRING. Instead of the w!() macro, this change relies on the internal util::encode_wide function to convert to a Vec<u16> with the Rust standard library.

@wravery
Copy link
Contributor Author

wravery commented Aug 31, 2022

This should take care of #443 and #444.

@wravery wravery marked this pull request as ready for review August 31, 2022 05:39
@wravery wravery requested a review from a team as a code owner August 31, 2022 05:39
@amrbashir
Copy link
Member

Thank you

@amrbashir amrbashir merged commit 84e1a9f into tauri-apps:dev Aug 31, 2022
@github-actions github-actions bot mentioned this pull request Aug 31, 2022
@wravery wravery deleted the windows-0.39.0 branch August 31, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants