Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
The
alloc
feature has been removed, which means Win32 APIs no longer accept RustString
or&str
parameters and implicitly convert them toPWSTR
orPSTR
.For string literals, that feature was replaced with
s!()
andw!()
macros which null terminate the string literal at compile time and convert to UTF-16 if necessary. Thes!()
macro is fine, however thew!()
macro usesHSTRING
types from WinRT for maximum compatibility with WinRT types. Since Tao only uses Win32 APIs (or dynamically loaded DLL entry-points), it still works on Win7, but I'm worried about taking any dependencies onHSTRING
. Instead of thew!()
macro, this change relies on the internalutil::encode_wide
function to convert to aVec<u16>
with the Rust standard library.