Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updater artifacts when available #129

Merged
merged 5 commits into from
May 13, 2021
Merged

Add updater artifacts when available #129

merged 5 commits into from
May 13, 2021

Conversation

lemarier
Copy link
Member

@lemarier lemarier commented May 3, 2021

Part of #108

@lemarier lemarier marked this pull request as ready for review May 10, 2021 21:20
@lemarier lemarier marked this pull request as draft May 10, 2021 21:43
@lemarier
Copy link
Member Author

Still failing
https://github.com/tauri-apps/tauri-action/actions/runs/829491498

Seems to be at github actions release level

@lemarier
Copy link
Member Author

await execCommand(`tar czf ${artifact}.tgz ${artifact}`, {

@lucasfernog
Copy link
Member

Seems like we need to escape the space.

@lemarier
Copy link
Member Author

lemarier commented May 11, 2021

Seems like we need to escape the space.

What you think if we remove this;

 if (artifact.endsWith('.app')) {
    await execCommand(`tar czf "${artifact}.tgz" "${artifact}"`, {
        cwd: undefined
    })
    artifacts[i] += '.tgz'
}

The bundler (when updater is enabled) already generates App.tar.gz because he needs to sign the final tar.gz so we can't do it inside the action.

Maybe later we can add the bundler to generate the tar.gz if the updater isn't enabled if we saw a need.

@lucasfernog
Copy link
Member

Issue fixed on #132

@lucasfernog lucasfernog marked this pull request as ready for review May 13, 2021 20:53
@lucasfernog lucasfernog merged commit 0e9704e into dev May 13, 2021
@lucasfernog lucasfernog deleted the feat/updater-assets branch May 13, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants