Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken asset release upload #45

Merged
merged 5 commits into from
Aug 23, 2020
Merged

fix: broken asset release upload #45

merged 5 commits into from
Aug 23, 2020

Conversation

jbolda
Copy link
Member

@jbolda jbolda commented Aug 23, 2020

Uploaded assets break when data receives fs.readFileSync(assetPath).toString() even though types suggest it. Giving it a Buffer fixes the issue.

@jbolda jbolda changed the title Fix/broken upload fix: broken asset release upload Aug 23, 2020
@jbolda jbolda merged commit cf98c66 into dev Aug 23, 2020
@jbolda jbolda deleted the fix/broken-upload branch August 23, 2020 19:44
@github-actions github-actions bot mentioned this pull request Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant