Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workspace cargo manifest #558

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

tr3ysmith
Copy link
Contributor

This is a potential fix for #557

This adds some logic to revert to the workspace manifest if version or name have the workspace key instead of a string.

This is currently untested.

@tr3ysmith
Copy link
Contributor Author

Currently testing on one of my workspace applications

@tr3ysmith
Copy link
Contributor Author

Initial test didn't change anything, going to try some other things

src/utils.ts Outdated Show resolved Hide resolved
@tr3ysmith
Copy link
Contributor Author

tr3ysmith commented Sep 22, 2023

I'll need to test this tomorrow but hopefully that does it! Thanks @FabianLars !

@FabianLars
Copy link
Member

Oh and one thing i missed is that you have to run pnpm build to rebuild the dist files (and commit them). Otherwise the changes won't be applied.

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FabianLars
Copy link
Member

welp, ci not agreeing with me there 😂

@FabianLars FabianLars merged commit d00117a into tauri-apps:dev Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Workspace version not supported, prints [object Object] to file names
2 participants