Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add appVersion output #645

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

A-kirami
Copy link
Contributor

Description

This pull request aims to enhance the utility of our GitHub Action by introducing a new output variable: appVersion. This addition serves the purpose of conveniently providing the version of the application being processed. The inclusion of this output variable will enable downstream workflows to easily access and utilize the current application version.

Changes Made

  • Added a new output variable appVersion to the existing list of outputs.
    • appVersion: The version of the application.

Context

The appVersion output is crucial for downstream workflows that depend on knowing the version of the application. This information can be utilized in various scenarios, such as deployment processes or other automated tasks.

Example Usage

jobs:
  example-job:
    runs-on: ubuntu-latest
    steps:
    - name: Checkout Repository
      uses: actions/checkout@v4

    - name: Run Tauri Action
      id: tauri-action
      uses: tauri-apps/tauri-action@v0
      with:
        # Other input parameters
        ...

    - name: Use 'appVersion' in Subsequent Steps
      run: |
        echo "Application Version: ${{ steps.tauri-action.outputs.appVersion }}"
      # Continue with other steps as needed

@FabianLars
Copy link
Member

Nice addition, thanks! Could you run pnpm install && pnpm build and commit the new dist files too please? Oh and a changefile like this one too https://github.com/tauri-apps/tauri-action/blob/dev/.changes/fix-member-globs.md

@A-kirami
Copy link
Contributor Author

All set! Updated dist files and added the changefile. 😊

Copy link
Member

@FabianLars FabianLars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@FabianLars
Copy link
Member

(i really need to update the real world tests so they don't just fail on external prs 😅)

@FabianLars FabianLars merged commit d618a42 into tauri-apps:dev Dec 18, 2023
4 of 7 checks passed
@A-kirami A-kirami deleted the add-version-output branch December 18, 2023 22:43
@moranbw
Copy link

moranbw commented Jan 19, 2024

I don't see this as available yet. Do I need to update my action somehow? VS Code plugin does not recognize appVersion output, but it does recognize the others like releaseId. I tried anyway, and it just showed up as blank in the subsequent step I tried to use it.

@FabianLars
Copy link
Member

Will be available once i merge #610. Should happen next week. If you need it urgently you can use the action from git directly via uses: tauri-apps/tauri-action@dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants