This repository has been archived by the owner on Jun 6, 2021. It is now read-only.
fix(codegen) compression usage when the paths are absolute #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
joiningPaths, if the path is absolute, Rust replaces the original Path. In that case, the includedir behavior of compressing the target file and move to OUT_DIR mutates the original file since we end up using the file path instead of${OUT_DIR}/${path}. This PR solves that behavior by removing the root from the source path when joining, so this behavior related to absolute paths doesn't happen.