-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] add support for cargo's workspace-inheritance
feature that has already been released in stable
#5070
Comments
I don't really keep track of nightly Rust, is this already in it? If so, I would be willing to co-operate with whatever cargo is planning. |
It's already stabilized in beta and will be published on stable in September with cargo 1.64, as I've mentioned in the original comment. |
while i would really like this for tauri, we are currently trying to support a MSRV of 1.59 |
Well, the feature is already in Rust 1.64, so it's already a stable feature, I don't think adding a check like "if for example version is a map instead of a string and contains EDIT: or did I misunderstand you and did you just mean that you're prioritizing getting the MSRV to 1.59 over implementing newer features? |
i havent tested this yet, but i want to prioritize these workspaces working completely with 1.59 using the tauri workspace as a path/git repo will break of course (i dont think thats a problem), but i would want to verify that the MSRV doesn't bump up when using |
👋 @withfig engineer here. We're using workspace inheritance for all of our internal crates now. We've got a workaround in place for our tao+wry app but this functionality would be really nice to have. In our case, the important thing is that |
workspace-inheritance
feature that's already in the rust beta branchworkspace-inheritance
feature that has already been released in stable
As best as i can tell, this is causing my |
Describe the problem
The
workspace-inheritance
feature that lets the programmer specify some stuff at the workspace level and refer to it within a given member crate'sCargo.toml
is already stabilized in beta 1.64 and is set to release in September, but from what I have seen it is still not supported in tauri, so I think it should already be implemented.By
not supported in tauri
I mean that thebuild.rs
script supplied bycargo tauri init
seems to try parsingCargo.toml
but fails withinvalid type: map, expected a string for key 'package.version' at line 3 column 21: invalid type: map, expected a string for key 'package.version' at line 3 column 21
Describe the solution you'd like
I'd like for tauri to successfully compile when I refer to workspace-wide settings within
Cargo.toml
Alternatives considered
No response
Additional context
Link to the feature: https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance
The text was updated successfully, but these errors were encountered: