Skip to content

fix: #2502 Expose set_menu from tao through the TrayHandle struct#2532

Merged
lucasfernog merged 4 commits into
tauri-apps:nextfrom
fnune:add-set-menu-to-systray-struct
Oct 2, 2021
Merged

fix: #2502 Expose set_menu from tao through the TrayHandle struct#2532
lucasfernog merged 4 commits into
tauri-apps:nextfrom
fnune:add-set-menu-to-systray-struct

Conversation

@fnune

@fnune fnune commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Some time ago we added set_menu for system trays: tauri-apps/tao#106
This API is not available via Tauri, and only set_icon is to be found inside app.tray_handle().

This PR exposes set_menu via the TrayHandle struct.

Disclaimer:

I'm not sure if this builds and runs correctly. I'm providing this as a draft PR and I'll be working on it based on feedback.

@lucasfernog lucasfernog marked this pull request as ready for review October 2, 2021 18:13
@lucasfernog lucasfernog requested a review from a team as a code owner October 2, 2021 18:13
@lucasfernog lucasfernog requested review from a team October 2, 2021 18:13

@lucasfernog lucasfernog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@fnune

fnune commented Oct 2, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for your contribution!

NP! Thanks for finishing it up!

@lucasfernog lucasfernog merged commit 0e4d12b into tauri-apps:next Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants