fix: #2502 Expose set_menu from tao through the TrayHandle struct#2532
Merged
lucasfernog merged 4 commits intoOct 2, 2021
Conversation
13 tasks
lucasfernog
approved these changes
Oct 2, 2021
lucasfernog
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution!
Contributor
Author
NP! Thanks for finishing it up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
set_menufrom tao through the TrayHandle struct #2502)Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Some time ago we added
set_menufor system trays: tauri-apps/tao#106This API is not available via Tauri, and only
set_iconis to be found insideapp.tray_handle().This PR exposes
set_menuvia the TrayHandle struct.Disclaimer:
I'm not sure if this builds and runs correctly. I'm providing this as a draft PR and I'll be working on it based on feedback.