Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error file name 'tauri.conf.js' to 'tauri.conf.json' #434

Merged
merged 7 commits into from
Feb 21, 2020
Merged

fix error file name 'tauri.conf.js' to 'tauri.conf.json' #434

merged 7 commits into from
Feb 21, 2020

Conversation

deftsp
Copy link
Contributor

@deftsp deftsp commented Feb 18, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@deftsp deftsp requested a review from a team February 18, 2020 17:21
@nothingismagick
Copy link
Sponsor Member

Hey! Thanks for catching this! I am not sure why the tests are failing will dig in in the AM.

lucasfernog and others added 5 commits February 21, 2020 15:18
@lucasfernog @nothingismagick
fix(tauri.js) if the DOM is already loaded, listen for <a> clicks (ta…
0122c21 
…uri-apps#436)

code is fine, the CI is borked
@lucasfernog @nothingismagick
fix(open) open <a> on browser only if target=_blank (tauri-apps#437)
e890895 
merging because CI is borked
@jbolda @nothingismagick
fix(tauri): make github action envs absolute for extra path level in …
0ba9730 
…runner.rs (tauri-apps#438)

* fix(tauri): extra path level in runner.rs

This file is one folder deeper than the other files which reference this env. This env is a relative folder reference so we need to concat an extra folder traversal into it.

* Revert "fix(tauri): extra path level in runner.rs"

This reverts commit eb1034b.

* make envs in GH Actions absolute for now

* runner is only available within steps
@lucasfernog @nothingismagick
feat(bundler) add exception_domain option by nothingismagick (tauri-a…
fb152c8 
…pps#439)
@renovate @renovate-bot @nothingismagick
chore(deps) Update Tauri JS CLI (tauri-apps#421)
6453b8a 
Co-authored-by: WhiteSource Renovate <renovatebot@gmail.com>
@deftsp deftsp requested a review from a team as a code owner February 21, 2020 14:18
@deftsp deftsp requested review from a team February 21, 2020 14:18
@nothingismagick nothingismagick merged commit c15a6d5 into tauri-apps:dev Feb 21, 2020
@nothingismagick
Copy link
Sponsor Member

THANKYOU

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nothingismagick nothingismagick nothingismagick approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deftsp @nothingismagick @jbolda @lucasfernog