Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundler/NSIS): Add Korean to supported NSIS languages #7010

Merged
merged 2 commits into from
May 19, 2023
Merged

feat(bundler/NSIS): Add Korean to supported NSIS languages #7010

merged 2 commits into from
May 19, 2023

Conversation

soumt-r
Copy link
Contributor

@soumt-r soumt-r commented May 19, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Relevant issue: #6906
Relevant PR: #6907 #6940

@soumt-r soumt-r requested a review from a team as a code owner May 19, 2023 21:05
@soumt-r soumt-r mentioned this pull request May 19, 2023
Closed
@amrbashir amrbashir linked an issue May 19, 2023 that may be closed by this pull request
[feat] Add Korean as available language for NSIS installers #6906
Closed
amrbashir
amrbashir previously approved these changes May 19, 2023
View reviewed changes
@amrbashir
Copy link
Member

Thank you for your contribution ❤️.

@amrbashir amrbashir changed the title feat(bundler/NSIS): Add Korean to supported NSIS languages. Partially fixes #6906. feat(bundler/NSIS): Add Korean to supported NSIS languages May 19, 2023
@amrbashir amrbashir merged commit 61e3ad8 into tauri-apps:dev May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Roadmap
Status: 🔎 In audit
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Add Korean as available language for NSIS installers
2 participants
@soumt-r @amrbashir