Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: refactor drag and drop events #1187

Merged
merged 7 commits into from
Mar 13, 2024
Merged

refactor!: refactor drag and drop events #1187

merged 7 commits into from
Mar 13, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir requested a review from a team as a code owner March 12, 2024 15:16
amrbashir
amrbashir commented Mar 12, 2024
View reviewed changes
Copy link
Member Author

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @wusyong @pewsheen can any of you test this on macOS using the simple.rs example?
the expected results should be:

DragEnter: <position> <paths>
DragOver: <position>
... multiple DragOver events
DragOver: <position>
DragLeave or DragDrop: <position> <paths>

@pewsheen
Copy link
Contributor

cc @wusyong @pewsheen can any of you test this on macOS using the simple.rs example? the expected results should be:

DragEnter: <position> <paths>
DragOver: <position>
... multiple DragOver events
DragOver: <position>
DragLeave or DragDrop: <position> <paths>

It looks good on macOS

pewsheen
pewsheen approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@pewsheen pewsheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also tested all platforms on my side.

@amrbashir amrbashir merged commit 5789bf7 into dev Mar 13, 2024
13 checks passed
@amrbashir amrbashir deleted the refactor/file-drop-handler branch March 13, 2024 12:15
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Merged
@xingrz xingrz mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pewsheen pewsheen pewsheen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @pewsheen