fix(android): moved currentUrl assignment to onPageStarted
#1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
force-pushed
the
fix/android-ipc-uri
branch
from
bc219a8
to
9adb67d
Compare
amrbashir
changed the title
currentUrl assignment to onPageStarted
|
I just faced this issue ,nice one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android, when Tauri opens a page with multiple scripts, some IPC calls gets invoked before
onPageFinishedcallback, causingIpc.postMessagenot retrieving correctcurrentUrl.This patch moved
currentUrlassignment toonPageStarted, so when frontend codes make any IPC calls, thecurrentUrlwill be up-to-date.Fixes tauri-apps/tauri#9502.