fix(linux): async custom protocol crashing sending response #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
reviewed
May 22, 2024
src/webkitgtk/web_context.rs
Outdated
| if let Some(content_type) = content_type { | ||
| response.set_content_type(content_type); | ||
| } | ||
| gtk::glib::idle_add(move || { |
There was a problem hiding this comment.
should we use MainContext::invoke instead? seems like idle_add might wait until the loop is idle which may impact performance, also MainContext::invoke will call the closure directly if it is already on the main thread.
There was a problem hiding this comment.
i knew that function existed - just couldn't find it in tao/wry
There was a problem hiding this comment.
sorted @amrbashir
did you forget to push 😂?
There was a problem hiding this comment.
🤣🤣🤣🤣 in my defense i was testing this while holding a baby
There was a problem hiding this comment.
no worries, anything for the baby ❤️
amrbashir
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
GTK may only be used from the main thread. thread 'tokio-runtime-worker' panicked at .cargo/registry/src/index.crates.io-6f17d22bba15001f/webkit2gtk-2.0.1/src/auto/uri_scheme_response.rs:26Ref tauri-apps/tauri#9794