Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled address generation using bip39 mnemonic #36

Closed
wants to merge 5 commits into from

Conversation

UVNishanth
Copy link
Contributor

  • modifications:
  1. client/miner has password to add salt for address generation
  2. blockchain has a mnemonic parameter and generates address for clients passed to its createInstance() using that mnemonic
  3. Late participants get the blockchain instance and use its mnemonic property to generate their address
  • not-clean-code:
    the blockchain isInstance might not be the best way to set late participant's address, but couldn't come up with a better solution

Copy link
Owner

@taustin taustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I've added a few suggestions/comments. Take a look and let me know when you are ready for me to review again.

blockchain.js Outdated Show resolved Hide resolved
blockchain.js Outdated Show resolved Hide resolved
client.js Outdated Show resolved Hide resolved
driver.js Outdated Show resolved Hide resolved
Copy link
Owner

@taustin taustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more minor fixes relating to comments, and then I think it is good to go!

mnemonic-driver.js Outdated Show resolved Hide resolved
driver.js Show resolved Hide resolved
Copy link
Owner

@taustin taustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@UVNishanth UVNishanth closed this Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants