Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArduBlock window will close without asking if you want to save your work. #151

Open
TonyCallear opened this issue Mar 29, 2016 · 5 comments

Comments

@TonyCallear
Copy link
Collaborator

Click the big 'X' to close ArduBlock and it just does it - no warning about losing unsaved work.

I've had a look on how to do this but there are many ptions and I just don't know enough Java to pick the correct one.

Hope someone can fix this?

@TonyCallear TonyCallear changed the title ArduBlock window can close without warning about unsaved work ArduBlock window will close without asking if you want to save your work. Mar 29, 2016
@heqichen
Copy link
Collaborator

×


This feature already in ardublock
if you did some change on canvas, ardublock will remind you if you click
the X button.

On Wed, Mar 30, 2016 at 6:34 AM, TonyCallear notifications@github.com
wrote:

Click the big 'X' to close ArduBlock and it just does it - no warning
about losing unsaved work.

I've had a look on how to do this but there are many ptions and I just
don't know enough Java to pick the correct one.

Hope someone can fix this?


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#151

@TonyCallear
Copy link
Collaborator Author

Hi,
I am not good at this - but I tried.
I got something which works when ardublock-all.jar is run by itself but it does not work when run from the Arduino IDE.

I have just noticed that... runing Ardublock from the menu in the Arduino IDE and clicking the 'X' -Close button in Ardublock does not close Ardublock - it just hides the window. If do some work in Ardublock, 'close' it and then click "tools - Ardublock" again in the Arduino IDE - all your work is still there.

As a silly example... In Main.java set
openblocksFrame.setDefaultCloseOperation(JFrame.DO_NOTHING_ON_CLOSE );
and ardublock-all.jar does not close when run on it's own. Run from the Arduino software and there is no change - it still 'closes'.

@TonyCallear
Copy link
Collaborator Author

Please see pull request #166

TonyCallear added a commit that referenced this issue Oct 28, 2017
Warn on close
Not a complete fix for #151 but HTH
@TonyCallear
Copy link
Collaborator Author

Perhaps see issue raised on the Arduino github

arduino/Arduino#6869

@TonyCallear
Copy link
Collaborator Author

If I understand #6869 correctly, there is no mechanism to interrupt the Arduino IDE closing from a tool like ArduBlock - and so ArduBlock silently dies and loses any unsaved work.

And no prospect of the Arduino IDE team coding that just for one little tool like ArduBlock either.

AFAICT other ways to lose work without warning are now taken care of??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants