Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issues #17

Merged
merged 2 commits into from
Oct 2, 2014
Merged

Some issues #17

merged 2 commits into from
Oct 2, 2014

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Sep 29, 2014

Two issues:

  1. Can't install the specified branch;
  2. Judge need Erlang 17 or not is not correct.

@@ -493,7 +494,7 @@ function install_elixir() {
git checkout -b "${version}" -f "${version}"
git pull origin "${version}"
else
git checkout -b "${version}" -f "v${version}"
git checkout -b "v${version}" -f "v${version}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an item I fixed earlier and neglected to push (now pushed). This can be removed.

@taylor taylor merged commit 3d2528f into taylor:master Oct 2, 2014
taylor added a commit that referenced this pull request Oct 2, 2014
@taylor
Copy link
Owner

taylor commented Oct 2, 2014

Thanks @jsvisa I merged your version checking then updated to use just bash + renaming for major, minor, patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants