Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala implementation #12

Merged
merged 1 commit into from
May 29, 2019
Merged

Add Scala implementation #12

merged 1 commit into from
May 29, 2019

Conversation

ihostage
Copy link
Member

@ihostage ihostage commented May 16, 2019

Fix #16

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #12 into master will increase coverage by 2.96%.
The diff coverage is 76.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #12      +/-   ##
============================================
+ Coverage     75.72%   78.68%   +2.96%     
- Complexity       56      119      +63     
============================================
  Files             5       14       +9     
  Lines           346      319      -27     
  Branches         90       70      -20     
============================================
- Hits            262      251      -11     
+ Misses           25       20       -5     
+ Partials         59       48      -11
Impacted Files Coverage Δ Complexity Δ
...org/taymyr/lagom/javadsl/openapi/OpenAPIService.kt 100% <ø> (ø) 1 <0> (?)
...taymyr/lagom/scaladsl/openapi/OpenAPIService.scala 100% <100%> (ø) 2 <2> (?)
...rg/taymyr/lagom/internal/openapi/ClassLevelInfo.kt 100% <100%> (ø) 5 <5> (?)
...g/taymyr/lagom/internal/openapi/ReflectionUtils.kt 100% <100%> (ø) 6 <6> (?)
.../taymyr/lagom/internal/openapi/LagomServiceInfo.kt 100% <100%> (ø) 3 <3> (?)
...myr/lagom/internal/openapi/AnnotationExtensions.kt 50% <50%> (ø) 20 <20> (?)
.../org/taymyr/lagom/javadsl/openapi/SpecGenerator.kt 57.14% <57.14%> (ø) 10 <10> (?)
.../taymyr/lagom/scaladsl/openapi/SpecGenerator.scala 63.63% <63.63%> (ø) 9 <9> (?)
...org/taymyr/lagom/internal/openapi/LagomCallInfo.kt 80% <80%> (ø) 3 <3> (?)
...org/taymyr/lagom/internal/openapi/SpecGenerator.kt 80% <80%> (ø) 4 <4> (?)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e456a1...587f52d. Read the comment docs.

@ihostage ihostage force-pushed the scala branch 6 times, most recently from a036cf8 to 8cd8776 Compare May 23, 2019 19:21
@ihostage ihostage changed the title [WIP] Add Scala implementation Add Scala implementation May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Lagom ScalaDSL
1 participant