This repository has been archived by the owner on Dec 21, 2019. It is now read-only.
Clean up DNS records after challenge verification #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not checking whether the record removal actually propagates into the nameserver or anything like that, this feature is purely for being a good DNS citizen.
This will call the DNS record removal functions after an ACME challenge has been completed successfully. This way records used for "old" challenges don't clutter up the DNS zones, which can cause problems when attempting to remove a zone through an infrastructure management tool like Terraform that won't know about the ACME verification records. Fixes #45
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #45 and the individual commits for more information.