Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update whisper.cpp version to 1.6.2 #142

Merged
merged 9 commits into from
May 28, 2024
Merged

Update whisper.cpp version to 1.6.2 #142

merged 9 commits into from
May 28, 2024

Conversation

arizhih
Copy link
Contributor

@arizhih arizhih commented Apr 23, 2024

No description provided.

@arizhih arizhih changed the title Update whisper.cpp version to 1.5.5 Update whisper.cpp version to 1.6.0 May 15, 2024
@arizhih arizhih mentioned this pull request May 15, 2024
Open
tazz4843
tazz4843 reviewed May 15, 2024
View reviewed changes
Copy link
Owner

@tazz4843 tazz4843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also regenerate bindings.rs. Given it was originally generated on a Linux machine, it should be regenerated on a Linux machine to minimize the diff. You can run bindgen -o src/bindings.rs wrapper.h -- -Iwhisper.cpp/ in /sys to do so.

src/whisper_ctx.rs Outdated Show resolved Hide resolved
src/whisper_ctx.rs Outdated Show resolved Hide resolved
@tazz4843
Copy link
Owner

See review comments

@arizhih
Copy link
Contributor Author

arizhih commented May 16, 2024

I've added wrapper, but really I don't know how to wrap whisper_rs_sys::whisper_aheads correctly because it contains pointers.

@hlhr202 hlhr202 mentioned this pull request May 17, 2024
Merged
@arizhih
Copy link
Contributor Author

arizhih commented May 17, 2024

I think now it safe and it's not possible to use it incorrectly. All raw int values are checked inside whisper.cpp on state creation step and error is returned if values are incorrect.

tazz4843
tazz4843 requested changes May 17, 2024
View reviewed changes
Copy link
Owner

@tazz4843 tazz4843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit but besides that looks good. Thanks :)

examples/audio_transcription.rs Outdated Show resolved Hide resolved
@arizhih arizhih changed the title Update whisper.cpp version to 1.6.0 Update whisper.cpp version to 1.6.2 May 27, 2024
@arizhih
Copy link
Contributor Author

arizhih commented May 27, 2024

@tazz4843 Hi, whisper.cpp released new minor version, nothing changed in API. I've decided to update my PR to the latest release.

@thewh1teagle
Copy link
Contributor

@arizhih
Tested on macOS. works great.

@thewh1teagle thewh1teagle mentioned this pull request May 28, 2024
Merged
tazz4843
tazz4843 approved these changes May 28, 2024
View reviewed changes
Copy link
Owner

@tazz4843 tazz4843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long, been dealing with the end of the school year 🥴
Looks good to me, thanks :)

@tazz4843 tazz4843 merged commit d7c2084 into tazz4843:master May 28, 2024
13 checks passed
@arizhih arizhih deleted the update-whisper-cpp branch July 9, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tazz4843 tazz4843 tazz4843 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arizhih @tazz4843 @thewh1teagle