Small optimizations (development, README, typings, rxjs) & forms API #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 28, 2016 09:08
…or dev-server for localhost and named hosts)
TobiasKrogh
force-pushed
the
new_forms_api
branch
from
09e1809
to
4f6db0c
Compare
Closed
|
I somehow did not manage to update the demo submodule content. Maybe you could include it directly without the submodule and ignore it upon updating the npm package... anyway: I did update the demo content and tested the new code, which works fine. Find attached the demo content. Cheers |
TobiasKrogh
changed the title
|
@TobiasKrogh thanks! I will check it evening and will handle the demo update. |
|
@tb great, thank you 👍 |
|
Thank you for handling it so quick :) works like a charm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit list (basically just some refinements and improvements) and finally changed the slider to the new forms api
EDIT: if you want I can also spit into smaller Pull Requests but I thought it might be ok since having individual commits