Fix two 'first run' bugs #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically this is seen the first time the program runs on a system. tb2097#59
Currently the UI displays a blank ExpressKey window the first time the program is run. If we create the config directory earlier in the process the ExpressKey panel will always be visible.
|
Hi Travis, |
|
Greetings Aaron,
Apologies for not getting this completed as of yet. I was ill for the past
week and have been trying to play catchup with work. I will try and get
this completed and release a new branch in the next 48 hrs.
Regards,
Travis Best
…On Tue, Feb 8, 2022 at 11:52 AM Aaron Skomra ***@***.***> wrote:
Hi Travis,
Did you have find any issues when looking over these patches?
Best Wishes,
Aaron
—
Reply to this email directly, view it on GitHub
<#62 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRJWX4IAFPA5SSWNSYUBOTU2FYBHANCNFSM5MZV6IDA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first run wacom-gui doesn't display the ExpressKey panel. Also on the first run there is a crash on exit (#59). This PR fixes these two issues.