Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the event handler is not removed #107

Closed
tbela99 opened this issue Jan 12, 2022 · 0 comments
Closed

the event handler is not removed #107

tbela99 opened this issue Jan 12, 2022 · 0 comments
Milestone
v0.3.4

Comments

@tbela99
Copy link
Owner

tbela99 commented Jan 12, 2022 •
edited
Loading

https://github.com/tbela99/css/blob/master/src/TBela/CSS/Parser.php#L111

array_splice($this->event_handlers[$event], $key, 0);

it should be

array_splice($this->event_handlers[$event], $key, 1);
tbela99 added a commit that referenced this issue Jan 12, 2022
@tbela99
#107 event handler was not removed
d25de75
@tbela99 tbela99 closed this as completed Jan 18, 2022
@tbela99 tbela99 added this to the v0.3.3 milestone Jan 18, 2022
@tbela99 tbela99 mentioned this issue Apr 29, 2022
Merged
tbela99 added a commit that referenced this issue May 3, 2022
@tbela99
Merge pull request #113 from tbela99/v.next
0b098f6 
#111 fix fatal errors
#109 fix file name resolution issue
#108 parsing and rendering performance improvement
#107 fix event handler removal issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.4
Development

No branches or pull requests
1 participant
@tbela99