Eliminate use of mktemp -- use mkstemp instead #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gsjaardema
commented
Aug 24, 2016
gsjaardema
commented
This reverts commit 0d1af3b.
This reverts commit a4e131b.
The use of mktemp() results in an unsuppressable warning message on certain compilers, including gcc. This causes problems for projects which have rules regarding warning-free compiles. Use mkstemp instead. The problem with mkstemp is that it opens the file instead of just returning a unique file name. However, as a side effect it does change the template to a unique file name. This can be used similarly to the return value from mktemp.
|
Thanks. Fails on Win though: https://ci.appveyor.com/project/tbeu/matio/build/1.5.8+build.14#L303 Need to check. |
|
Changes Unknown when pulling 328b6b7 on gsjaardema:master into * on tbeu:master*. |
|
Changes Unknown when pulling 328b6b7 on gsjaardema:master into * on tbeu:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.