Add 'autoconf' to 'Quick Build Guide' #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For someone strictly following the 'Quick Build Guide' running './configure' will produce 'bash: ./configure: No such file or directory'. To spare others the same problem 'autoconf' was added to the guide which will produce the missing configure script with the given 'configure.ac'.
1 similar comment
|
Note, there is a difference between building the lib from the repo or building from the distribution. README is meant for the distribution, where configure is available. |
|
I fixed the encoding issue in both READMEs though. Thanks for reporting it. |
|
Sure, no problem. |
papadop
pushed a commit
to papadop/matio
that referenced
this pull request
Nov 29, 2017
As reported by tbeu#63 [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For someone strictly following the 'Quick Build Guide' running './configure' will produce 'bash: ./configure: No such file or directory'. To spare others the same problem 'autoconf' was added to the guide which will produce the missing configure script with the given 'configure.ac'.
I did not change anything on line 42 but GitHub automatically changed the encoding of the file from ISO-8859-1 to UTF-8, which I guess is leading GitHub to mark the line as changed.