-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several cmake improvements #75
Conversation
Can you ask a pull request to the New cmake branch ? If you can drop the getopt CMakeLists.txt that would be great as I already added the one from OpenMEEG-matio. Thank's for all the suggestions. I skimmed through them quickly and they seem to be nice improvements (which also show that we never built OpenMEEG-mtio on windows with many of the options) |
…r value if #if should be used
Dear @papadop , I just pulled in your latest changes and rebased my changes on top of yours. I also removed my getopt CMakeLists.txt. I will test now and then push the update. |
A minor thing: your getopt library is called |
The getopt library is needed to build the tools and the testing utility test_mat. Whether it is needed to install it depends on the way it is linked into the executables. I tend to think that it is linked dynamically, which means that if you install the tools or the test_mat utility then you also need to install the getopt lib. |
As for the name, I do not think I changed anything. But I do not know where I got this. Looking at the CMakeLists.txt it seems that we build a static library, so there is no need to install it and we can name it getopt which is probably better than gnu indeed. |
Great, I agree. Then I'll make these minor changes too. |
4 similar comments
ab358d5
to
c7da7bf
Compare
d982732
to
5dfe2db
Compare
Is this still being worked on? If not, I propose to close it w/o merge? |
I intend to continue on working on thé branch... Please do not close it. |
Any updates? If matio supported |
Sorry, no news here. Autotools and VS solutions are the supported build environments. See https://github.com/tbeu/matio#20-building |
4ff7b1e
to
4f964f8
Compare
3846a94
to
0904d31
Compare
b97f68d
to
be83cfb
Compare
I would close this one in favor of #107 |
Let's see it it works automatically once I merge #107. |
622a081
to
aefd09e
Compare
Doing so. |
Still work in progress.