Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP authentication #10

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Add LDAP authentication #10

merged 2 commits into from
Apr 11, 2023

Conversation

Danoontjes
Copy link
Contributor

This patch adds LDAP authentication to mian. It moves the mail server config variables as well as the LDAP config variables to an extra config.ini file. When 'LDAP_ACTIVE = false' it behaves the same as before.

@Danoontjes Danoontjes changed the title Add LDAP athentication Add LDAP authentication Apr 7, 2023
mian/main.py Outdated
Comment on lines 117 to 128
# def get_config_section():
# if not hasattr(get_config_section, 'section_dict'):
# get_config_section.section_dict = collections.defaultdict()

# for section in config.sections():
# get_config_section.section_dict[section] = dict(config.items(section))

# return get_config_section.section_dict

# # Load config file variables into config_dict.
# # Variable names are converted to lowercase!
# config_dict = get_config_section()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of places with commented out methods. Are you keeping them for reference or do they serve some other purpose?

Copy link
Owner

@tbj128 tbj128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment in main.py regarding the commented out methods. LGTM otherwise.

@Danoontjes
Copy link
Contributor Author

Sorry, just forgot to remove them.

@tbj128 tbj128 merged commit fdd3200 into tbj128:master Apr 11, 2023
@tbj128
Copy link
Owner

tbj128 commented Apr 11, 2023

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants