-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix async search clicks #108
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tbleckert/react-select-search/2gs8izvhm |
Upon further testing, I'm not convinced my current changes actually fix anything. It looks like there's no ID making it to this line, and thus no selection taking place. Is one expected to provide the |
# Conflicts: # src/useSelect.js
@davidangel Sorry for the delay and thanks for the PR. From what I can tell, your fix seems to fix the issue. Regarding your comment. Yes, a value is needed on the option element. It is included in the DOM props sent to the render callback (https://github.com/tbleckert/react-select-search/blob/master/src/Components/Option.jsx#L20). I think the problems came with the introduction of number support for values. In the linked file you can see that I set I'll merge this in and prepare it for testing and a patch release. |
Addresses #107 (and I believe #92 - unsure why this didn't get merged?)